Say in the GUI what the tool actually reads - #203
Merged
Merged
Conversation
The input heading said "Select the file (tar/zip/gz) or directory", which has been wrong since raw disk images landed on 30 August: the file dialog also takes .img, .bin, .dd, .raw, .001, .E01 and .iVa. A GUI user was told the tool takes three archive formats when it takes a disk image and a Berla iVe export as well. Nothing in the GUI named a filesystem either. The dialog offered "raw disk image or acquisition" and left the extensions to speak for themselves, and an extension says nothing about what is inside: a .dd can hold any of these or nothing this reads. The -t help on the command line spells the list out, so a GUI user had to open a terminal to learn what their own tool supports. The heading now names the accepted inputs and the dialog entry names the filesystems, taken from the same list the command line gives so the two cannot drift apart silently. Text only. No behaviour changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input heading said "Select the file (tar/zip/gz) or directory". That has been wrong since raw disk images landed on 30 August (
bb6dd6a): the file dialog also takes.img,.bin,.dd,.raw,.001,.E01and.iVa. A GUI user was told the tool takes three archive formats when it takes a disk image and a Berla iVe export as well.Nothing in the GUI named a filesystem at all. The dialog offered "raw disk image or acquisition" and left the extensions to speak for themselves, and an extension says nothing about what is inside: a
.ddcan hold any of these or nothing this reads.vleapp.py -hspells the list out, so a GUI user had to open a terminal to learn what their own tool supports.The filesystem list is a module constant next to
RAW_IMAGE_SUFFIXES, and it is checked against the wording invleapp.py's-thelp so the two cannot drift apart silently. Every name in the GUI list appears in the CLI help.Text only, no behaviour changes. Verified by running the GUI from source and reading the heading off the window.
🤖 Generated with Claude Code