Re-vendor qnxprobe 1.18: the sealed macOS system volume - #200
Merged
Merged
Conversation
1.17 reported the system volume of a Big Sur or later Mac as holding no files. Not an error: a successful walk returning zero, which reads the same as an empty disk. 1.18 reads it. Checked through the vendored copy against the Big Sur test acquisition rather than through the suite, which never touches a Mac image: Macintosh HD goes from 0 to 443,131 entries, its own superblock's count of files plus symlinks, and the other five volumes are unchanged to the file. No capability list changes. This adds no filesystem, it makes one that was already named actually readable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored reader from 1.17 to 1.18.
1.17 reported the system volume of a Big Sur or later Mac as holding no files. Not an error: a successful walk returning zero, which reads the same as an empty disk. 1.18 reads it.
Checked through the vendored copy against the Big Sur test acquisition, not through the suite, which never touches a Mac image:
Macintosh HDgoes from 0 to 443,131 entries, which is its own superblock's count of files plus symlinks, and the other five volumes are unchanged to the file.No capability list changes. This adds no filesystem, it makes one that was already named actually readable. ewfprobe is unchanged. Suite: 218 passed, 3 skipped; drift guard clean against the upstream checkout.
🤖 Generated with Claude Code