Re-vendor qnxprobe 1.17: HFS+ and APFS volumes - #199
Merged
Merged
Conversation
The vendored copy was 1.14, which does not recognise HFS+ or APFS at all. Measured on the reader's own fixture images with the old copy and the new one: APFS went from no volumes extracted to 411 files, HFS+ from none to 412, NTFS unchanged at 488. Proven through FileSeekerRaw rather than the command line alone. The staged bytes match what an independent reader recorded for each fixture: APFS 411 of 411, NTFS 475 of 475, HFS+ 411 of 412, the one gap being the symlink the reader reports as skipped. 1.17 also carries two fixes that landed after 1.16. The NTFS walker no longer follows a directory index entry whose file reference names a different record generation, so a reused record is no longer reported under the name an old entry left behind. The APFS lookup no longer rebuilds its leaf-key list on every call. The four places that enumerate what -t raw reads are brought up to date. admin/docs/raw_image_input.md had also been missing NTFS since it was added. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored reader from 1.14 to 1.17, which adds HFS+ and APFS.
FileSeekerRaw, not the command line alone. Staged bytes match what an independent reader recorded per fixture: APFS 411 of 411, NTFS 475 of 475, HFS+ 411 of 412, the gap being the symlink the reader reports as skipped.-t rawreads are updated.admin/docs/raw_image_input.mdhad also been missing NTFS since it was added.ewfprobe is unchanged and still matches its upstream. Suite: 218 passed, 3 skipped.
🤖 Generated with Claude Code