Report the PAS log timestamp as recorded, not as UTC - #191
Merged
Merged
Conversation
The pas_debug log writes the head unit's own clock and records no zone on the line. The module typed that value as a datetime and stamped it UTC, so the report, the timeline and the LAVA database all read it as a UTC instant. It is not one. The log publishes UTC on its own lines, and comparing the two gives 4 hours behind UTC on 405 of 412 comparisons in the committed Sync 4 case, the other 7 differing by a minute because the published value carries no seconds. A Sync Gen3 extraction checked the same way against the GPS UTC it receives gives 4 hours on 38 of 51 pairs, 5 hours on 4 and 6 hours on 7, so the offset is not constant and cannot be assumed. Every Dev Loc row was therefore being placed 4 hours before it happened. Dropping the tzinfo alone would not have fixed it: lavafuncs coerces a naive datetime to UTC, so the same wrong instant would have been stored with nothing in the artifact to show it. The column is no longer declared a datetime, so the reading is carried as recorded and no instant is asserted. The KML and timeline key on the header name, not the type, and both still carry the value. Row counts are unchanged on every artifact and the only column that moves is Timestamp. Sub-second precision now survives, which the epoch integer dropped. The notes say what the value is and name the VS_CLOCK_QUEUE lines that record the offset, so an examiner can establish it per extraction. Baselines re-recorded and shown to fail against the previous behaviour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reports the PAS log timestamp as recorded rather than as UTC.
The log writes the head unit's local clock and states no zone on the line. The column was typed
datetimeand stamped UTC, so every row was placed 4 hours before it happened.lavafuncscoerces a naive datetime to UTC.Row counts are unchanged and Timestamp is the only column that moves. The notes name the VS_CLOCK_QUEUE lines that record the offset. Baselines re-recorded and shown to fail against the previous behaviour.
🤖 Generated with Claude Code