Let the GUI open a raw disk image - #170
Merged
Merged
Conversation
The GUI decides the input type from the file extension, so a raw image picked there arrived as 'img' or 'bin', which matches no branch in crunch_artifacts. The run then produced a report with nothing in it rather than an error, which reads as though the image held no data. Two changes, both in vleappGUI.py. The conventional raw image extensions map onto the raw input type, and the file picker offers them so an image can be selected at all. The seeker dispatch is shared with vleapp.py, so nothing else was needed. An image named something else is still reachable from the command line with -t raw. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GUI picks the input type from the file extension, so a raw image selected there arrived as
imgorbin, matched no branch incrunch_artifacts, and produced an empty report rather than an error.Two changes, both in
vleappGUI.py, 17 lines:img,bin,dd,raw) map onto therawinput typeThe seeker dispatch is shared with
vleapp.py, so nothing else was needed. An image named anything else is still reachable from the command line with-t raw.