Vendor qnxprobe for QNX6 and ext volume access - #168
Merged
Merged
Conversation
qnxprobe reads QNX6 and ext2/3/4 volumes out of a raw image without mounting and without administrator rights. Vehicle head units run both: the Ford Sync units in the test corpus are QNX6 and the BMW MGU is ext4, and no filesystem type Sleuth Kit supports can walk QNX6 at all. It is one file and uses only the standard library, so requirements.txt is unchanged. Copied verbatim into scripts/vendor/ with its licence. Nothing imports it yet. A vendored copy drifts in two directions and both are silent: an edit here looks like a fix until the next re-vendor reverts it, and an upstream release leaves this copy quietly old. scripts/vendor/vendored.json records the upstream commit and sha256, check_vendored.py fails when the file stops matching that record, and with --upstream it also fails when upstream has moved on. It runs in CI unconditionally, because the record lives in a .json and a stale record is the same defect. lint_changed.py now skips scripts/vendor/. Linting a verbatim copy would fail the job on 21 warnings that are not ours to fix, and both ways to silence them, editing the copy or adding a file-level disable, turn the next re-vendor into a merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors qnxprobe into
scripts/vendor/so VLEAPP can read QNX6 and ext2/3/4 volumes out of a raw image without the examiner installing anything. Standard library only, so requirements.txt is unchanged. Nothing imports it yet; that comes in the next PR.scripts/vendor/vendored.jsonrecords the upstream commit and sha256.admin/scripts/check_vendored.pyfails when the copy stops matching that record, and with--upstreamwhen upstream has moved on. Runs in CI.lint_changed.pyskipsscripts/vendor/, since a verbatim copy is guarded by hash rather than style.