Count the vzmobile known value, and report media absence as observed - #462
Open
OneSixForensics wants to merge 1 commit into
Open
OneSixForensics wants to merge 1 commit into
OneSixForensics wants to merge 1 commit into
Conversation
Both raised in review on abrignoni#452, neither blocking. The vzmobile entry in the generator's `actual` map was the literal 3 rather than a count of what was written, so it compared 3 against 3 and could not fail. The other seven keys are computed, which is the whole reason the block is worth having. It now walks the VZMOBILE folder the way mms_media_files walks the attachment folders. Verified by declaring 4: the generator exits 1 with "vzmobile: declared 4, emitted 3" where before it printed and passed. The Link Status string still read "referenced — file not in daily folder; possibly quarantined/removed". The notes now explain that absence there is expected for reported content, but the string is what lands in the examiner's column, and it offered a cause the artifact cannot distinguish: a file absent because it was quarantined and one absent for any other reason produce the same observation. It now reads "referenced — no file of this name in the MMS media folders", which is what was actually checked, and the notes carry the quarantine explanation along with the point that absence alone does not establish why a given file is missing. last_update_date bumped on both MMS artifacts, since the string is user-visible. Only synchronoss_mms_received's baseline changes; the other nine are untouched. Verified: committed case 10/10 PASS, real rleapp.py -t fs run reports the new string and the same counts as the harness (uploads 11, sync 8, messages 12, calls 2, contacts 4, mms 6/1/1, quarantined 4, vzmobile 3), pytest 168 passed plus 193 subtests, pylint 10.00/10, admin checkers clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Thanks for the contribution! This PR changes artifact modules without test data for them. A small fixture with each artifact change lets reviewers run the module against real data, and the committed case keeps guarding the module after merge.
Adding a fixture Generate it from your extraction with the helper (details in create_module_test_cases.md): It writes Size rules:
If your extraction cannot be shared:
If none of those fit, say so here and we will work it out. The PR can still be reviewed and merged with the gap recorded in the artifact's This is a request, not a gate. Nothing here blocks review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups you raised on #452 after it merged. You said neither was worth a PR on its own, so they are together here.
1. The vzmobile known value could not fail
The generator asserts its declared known values against what it actually wrote, which is what makes the fixture worth trusting.
actual["vzmobile"]was the literal3rather than a count, so it compared 3 against 3 and could never go red. The other seven keys are computed.It now walks the VZMOBILE folder the way
mms_media_fileswalks the attachment folders. Verified by declaring 4:exit 1, where before it printed and passed.
2. Link Status offered a cause the artifact cannot distinguish
The notes explain that absence is expected for reported content, but the string is what lands in the examiner's column, and a file absent because it was quarantined and one absent for any other reason produce exactly the same observation. The cell now states what was checked; the notes carry the quarantine explanation, and now also say that absence alone does not establish why any one file is missing.
last_update_datebumped on both MMS artifacts, since the string is user-visible.Verified
Only
synchronoss_mms_received's baseline changes; the other nine are untouched.rleapp.py -t fsrun reports the new string, with the same counts as the harness: uploads 11, sync 8, messages 12, calls 2, contacts 4, mms 6/1/1, quarantined 4, vzmobile 3pytest admin/test/scripts205 passed plus 239 subtestslint_changedno new warnings, admin checkers clean