Stop reading an ESE database at the end of a file cut short - #359
Merged
Merged
Conversation
The vendored reader's getPage reads until it has a whole page, so a page past the end of a truncated copy made it wait forever and the run never finished. ESEDatabase is the vendored reader with a getPage that raises PageOutOfRange there instead. TableRows stops a table at such a page, keeps the records read before it and names the table and page in the run log. WebCache, SRUM, Windows Search, the Thumbnail Cache and BITS open their databases with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each ESE artifact's notes now say that a table in a database file cut short is read up to the first of its pages past the end of the file and that the run log names it, with what copies of a tested image's file cut to 90, 75, 50 and 25 percent of its length gave. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops a truncated ESE database from hanging the run.
scripts/ese_rows.ESEDatabasereads pages the same way but raises there instead, andTableRowsstops that table, keeps the records read before it and names the table and page in the run log.🤖 Generated with Claude Code