fix(story): require release-style active summary for open-turn publish#9
Open
mosure wants to merge 1 commit into
Open
fix(story): require release-style active summary for open-turn publish#9mosure wants to merge 1 commit into
mosure wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
active_progress_summaryto bypass the stricter open-turn gate incompile_active_update, enabling transcript-derived assistant lines to become publishable active-update stories before turn completion and risking private context disclosure.active_update_summarypredicate for open-turn publication.Description
active_progress_summary_for_project(...)fromStoryCompiler::compile_active_updateso open-turn flushes only proceed whenactive_update_summary_for_project(...)passes.compile_activity_checkpoint(...), preserving non-sensitive progress signaling without publishing transcript-derived active updates.active_progress_message_does_not_publish_without_turn_completionand changed its assertion to ensure active-progress-only messages do not publish before turn completion.cargo fmt --allto apply formatting changes.Testing
cargo fmt --alland it completed successfully.cargo +1.92.0 test -p agent_feed_story active_progress_message_does_not_publish_without_turn_completion --ignore-rust-version --offline -- --nocaptureand the test passed.cargo +1.92.0 test -p agent_feed_story meaningful_agent_message_publishes_after_flush --ignore-rust-version --offline -- --nocaptureand the test passed.cargo +1.92.0and--ignore-rust-versionto run in the validation environment.Codex Task