fix(ui): block browser forwarding of CLI OAuth callback states#6
Open
mosure wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
stateto the edge, which could enable session token exfiltration via malicious redirect URIs.feed:-encoded OAuth state that does not indicate a CLI client.Description
forwardRawGithubOauthCallbackincrates/agent_feed_ui/src/reel.tsto decode thestatevalue and refuse forwarding when it is not a decodablefeed:payload or when the decodedclientends with-cli.decodeFeedOauthStateClienthelper to safely parse thefeed:hex-encoded JSON state and extract theclientfield, failing closed on malformed values.crates/agent_feed_ui/src/lib.rsto reflect the new guard logic and helper function.Testing
cargo test -p agent_feed_ui --ignore-rust-version, iterating until expectations matched the updated output.29 passed; 0 failed).Codex Task