fix: require authority key for browser p2p headlines#3
Open
mosure wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StoryCapsuleon subscribed gossipsub topics, allowing unauthenticated peers to inject live headlines that would appear "verified" in the UI.Description
authority_idtoBrowserPeerStartConfigso the browser runtime has an expected signing authority (crates/agent_feed_p2p_browser/src/lib.rs).handle_story_messageto reject incoming capsules whosesigned.signature.key_iddoes not match the configuredauthority_id(afterverify_capsule()and before converting to aRemoteFeedHeadline) (crates/agent_feed_p2p_browser/src/lib.rs).crates/agent_feed_ui/src/reel.ts).Testing
cargo test -p agent_feed_p2p_browserfailed due to local toolchain mismatch (rustc 1.89.0vs crate-required1.95), so the non-ignored run could not execute.cargo test -p agent_feed_p2p_browser --ignore-rust-versionand all browser-p2p unit tests passed (13 passed; 0 failed).Codex Task