fix: disable unauthenticated native discovery fallback#2
Open
mosure wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
provide_keyreturn an error until discovery authorization is implemented.discover_providersreturn an error until discovery authorization is implemented.register_rendezvous_namespacereturn an error until discovery authorization is implemented.native_rendezvous_kad_provider_fallbacktofalseand add thenative_rendezvous_kad_provider_fallback_not_integratedknown gap, and adjust unit tests to assert the secure-by-default behavior.Testing
cargo test -p agent_feed_p2p -p agent_feed_edge --locked --libwith the local rustc failed due to a toolchain mismatch (project requires newer Rust).cargo +1.92.0 ... --ignore-rust-versionand verifiednative_libp2p_kad_provider_fallback_is_disabled_until_authorized,native_libp2p_rendezvous_fallback_is_disabled_until_authorized, andnative_libp2p_live_service_skips_configured_discovery_when_disabledall passed.readyz_reports_data_plane_gaps_and_durable_controlspassed after updating the readiness payload and known gaps.Codex Task