Honor GPIO pull-up/down on ESP32S3 inputs - #2
Merged
Merged
Conversation
Apply IOMUX pull states to input pins so default PULL_UP/PULL_DOWN values are reflected in GPIO_IN when pins are not driven. This prevents gpio's being initialized low (until their value is set) while actually configured as PULL_UP, for instance.
Author
|
Just FYI, this work was done by the https://MicroPythonOS.com/ team to allow running a normal MicroPythonOS build (which works on many boards, including the LilyGo T-Display-S3) on an emulated esp32s3. Thank you for all your great work on QEMU for the ESP32 and ESP32S3! |
dzo
approved these changes
Apr 2, 2026
dzo
left a comment
dzo
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks for your work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply IOMUX pull states to input pins so default PULL_UP/PULL_DOWN values are reflected in GPIO_IN when pins are not driven. This prevents gpio's being initialized low (until their value is set) while actually configured as PULL_UP.