fix(scene-source): stop stranding stale browser_source on re-point (#110)

[ClodoCapeo]

Closes #110

Problem

on_set_capture_source created the new browser_source under the canonical name PulsarSceneSource before removing the old one. While the old source still held that name, libobs de-duped the fresh instance to PulsarSceneSource 2; remove_managed_items matched by exact strcmp and thus missed every numbered variant, which accreted on the program scene indefinitely. From the 3rd re-point on, a name-based consumer (Prism's findBrowserSourceName, first browser_source item) could lock onto a stale instance — the real-world symptom: REC on an atlas scene showing only the native camera, never the Solar overlay.

Fix

plugins/pulsar-scene-source/src/plugin-main.cpp:

• Remove managed items before adding the fresh source; the scene held the old source's only ref, so removing the item frees the canonical name synchronously.
• Reclaim the canonical name on the fresh source once it is free (obs_source_set_name) — the surviving instance is always PulsarSceneSource, never a numbered variant. No-op on the first call.
• remove_managed_items now matches libobs de-dup variants (base or base <digits>, precisely — not a loose prefix), sweeping any pre-existing drift without over-matching an unrelated PulsarSceneSourceCustom.
• The create-first order is kept for the availability check, so a light build (no obs-browser) still returns browser_source_unavailable without touching the scene.

Test

scripts/probe-scene-name-drift.py (connect-only, wired into the offline probe suite / CTest via run-probes.ps1): drives pulsar-scene:SetCaptureSource N=6 times against the shared pulsar.exe and asserts, after every call, that the program scene holds exactly one managed browser_source and that it carries the canonical name. This is the websocket-boundary equivalent of the investigation's probe_name_drift.py (pure libobs state, no CEF paint / GPU). Light build → typed exit-3 skip, same pattern as probe-browser-m3.py.

Not validated here

Real CEF pixel compositing after re-point (needs an interactive desktop + Solar) is out of CI scope by doctrine — the antenna/live path covers it.

🤖 Generated with Claude Code