Repository navigation
Fix printing-info never exiting without a system D-Bus - #5119
Merged
totaam merged 1 commit intoNov 4, 2026
Merged
Conversation
The command only takes a snapshot or submits a job and never uses printer change notifications, so don't initialize them: without a system D-Bus, pycups falls back to a non-daemon polling timer which re-arms itself and keeps the process alive.
Collaborator
|
This module was also used on win32 as Lines 2896 to 2897 in 4b839ed But I believe it has now been superseded by PDFIUM_Print.exe:Lines 2849 to 2851 in 4b839ed As used here: xpra/xpra/platform/win32/printing.py Line 218 in 4b839ed So I'm going to merge this despite having some doubts. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xpra printing-infonever exits when there is no system D-Bus, which is commonin containers: it prints the printer list and then hangs until interrupted.
init_printing()falls back to the CUPS polling timer, a non-daemon thread whichre-arms itself every 60 seconds. For the same reason, the
printing-infocheck inunit.scripts.main_testfails after its 60 second timeout on such hosts.The command only takes a snapshot or submits a job and never uses printer change
notifications, so don't initialize them there. The client still initializes and
cleans up its own watcher.
The new test runs
printing-infowith an unreachable system bus and CUPS server:it times out without this change and exits with the connection error with it.