Onchain Cosigner - #613
Open
shawnxie999 wants to merge 7 commits into
Open
Conversation
The previous design reported one signed_weight/quorum pair, which cannot describe a proposed Batch where the outer account and every inner participant each have their own quorum. Replaces it with a signing_status array, defines the completeness evaluation precisely, and resolves the 'Completion signalling' open question. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * XLS-0103 §8: correct stale-signer semantics; add ledger-freshness caveats A collected Signers entry the live SignerList no longer authorizes voids the whole set at submission rather than merely losing its weight, and the voided set cannot be repaired because signatures only accumulate (§8.1.3.2, §13.5). Document ledger-state changes that invalidate a complete verdict (LoanBroker deletion, DelegateSet revocation, the Batch exact-set rule) and direct clients to evaluate against the most recent validated ledger (§8.1.3.4). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * address PR comments * minor: specify inadequate_signatures field --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
shawnxie999
marked this pull request as ready for review
August 26, 2026 15:36
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
| "account": "rTARGET..........................", | ||
| "role": "account", | ||
| "signed": false, | ||
| "reason": "below_quorum", |
There was a problem hiding this comment.
Enum mismatch: reason table (§8.1.2) omits below_quorum, no_signature from examples (§8.1.6). Add both:
| `no_signature` | Single-Sign: no signature received.
| `below_quorum` | Multi-Sign: below quorum weight.
| "account": "rTARGET..........................", | ||
| "role": "account", | ||
| "signed": false, | ||
| "reason": "below_quorum", |
There was a problem hiding this comment.
Spec mismatch: Examples use undefined below_quorum/no_signature (appears here and later). Replace with inadequate_signatures:
Suggested change
| "reason": "below_quorum", | |
| "reason": "inadequate_signatures", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change