Implement host shortcuts for closing apps and switching windows - #324
Open
korefs wants to merge 4 commits into
Open
Implement host shortcuts for closing apps and switching windows#324korefs wants to merge 4 commits into
korefs wants to merge 4 commits into
Conversation
- Added functionality to define key combinations for host shortcuts (Alt+F4 to close the current app and Alt+Tab to switch windows). - Introduced a new KeyComboAction enum to manage different key combinations. - Created a dialog for setting up key combinations, including conflict detection. - Updated settings management to handle key combo options and conflicts. - Refactored button selection logic in the settings and in-game overlay views to utilize the new key combo system. - Enhanced localization files to include new strings for host shortcuts.
…urante o streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, unified approach for configuring controller button combinations (key combos) for various actions, and adds support for customizable host shortcut combos (such as sending Alt+F4 or Alt+Tab to the host). The changes consolidate and refactor key combo configuration code, improve UI consistency, and update documentation to reflect the new features.
Key Combo Configuration Refactor and Host Shortcut Support
Unified key combo configuration:
Introduced
key_combo_settings.hppandkey_combo_settings.cppto centralize logic for displaying and editing key combo settings, replacing duplicated code in bothSettingsTabandOptionsTab. Now, all key combo cells and dialogs use shared helper functions for consistent behavior and appearance. [1] [2] [3] [4]Updated
ButtonSelectingDialog::createto support anallowDisableparameter, letting users explicitly disable a key combo via the dialog. [1] [2] [3]Removed redundant per-class implementations of button combo display and selection logic, replacing them with calls to the new shared helpers. [1] [2] [3]
Host shortcut support:
Documentation and guidelines:
README.mdto document the new host shortcut features and their configuration.AGENTS.mdwith repository structure, coding style, and contribution guidelines for improved project onboarding and consistency.These changes make key combo configuration more robust, easier to maintain, and enable new functionality for host shortcuts.