fix(ios): remove super invalidate (NativeFlic2SpecBase) - #57
Merged
Conversation
NativeFlic2SpecBase is NSObject and does not declare invalidate, which breaks Xcode builds. Keep our invalidate cleanup; RN still finds it via respondsToSelector. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes an iOS compilation failure in the native module by removing an invalid [super invalidate] call from Flic2’s -invalidate implementation while keeping the module’s cleanup behavior (rejecting a pending initialize promise) intact.
Changes:
- Remove
[super invalidate]from-invalidateto avoid calling a selector not declared on the generated base class. - Preserve cleanup behavior by continuing to reject any in-flight
initializewithMODULE_INVALIDATED. - Add an explanatory comment clarifying why
-invalidateexists without a super call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Cursor <cursoragent@cursor.com>
XGManuelJager
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NativeFlic2SpecBase(NSObject) does not declareinvalidate, so[super invalidate]does not compile.-invalidatecleanup (reject pending init); RN still invokes it viarespondsToSelector.Test plan
npm run lint/npm run typecheckFlic2.mminitializewithMODULE_INVALIDATEDMade with Cursor