Repository navigation
fix: prevent premature false return from RingBuffer Offer under contention - #240
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
…ntion In the MPMC RingBuffer put method, when offer is true, a failed CAS contention or slot lag previously caused put to fall through and immediately return false, nil as if the queue were full even when ample capacity remained. Check whether the ring buffer is genuinely full before attempting slot reservation and retry upon CAS contention when capacity is available. Add concurrent regression test TestRingQueueOffer_parallel. Fixes Workiva#213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the MPMC RingBuffer put method, when offer is true, a failed CAS contention or slot lag previously caused put to fall through and immediately return false, nil as if the queue were full even when ample capacity remained.
Check whether the ring buffer is genuinely full before attempting slot reservation and retry upon CAS contention when capacity is available. Add concurrent regression test TestRingQueueOffer_parallel reproducing multiple goroutines invoking Offer concurrently.
Fixes #213