Skip to content

Support: Remove duplicate rules - #995

Open
timse201 wants to merge 2 commits into
WordPress:trunkfrom
timse201:patch-21
Open

timse201 wants to merge 2 commits into
WordPress:trunkfrom
timse201:patch-21

Conversation

@timse201

@timse201 timse201 commented Oct 2, 2026 •

Copy link
Copy Markdown

CSS: Remove duplicate :root, body declarations and redundant selectors

  • Remove redundant :root, body declarations.
  • Deduplicate #bbpress-forums fieldset.bbp-form legend selector.
  • Remove redundant .bbpress #bbpress-forums .bbp-topics ul.sticky rule.

Summary by CodeRabbit

  • Style
    • Simplified support-theme styling by removing repeated color declarations and superseded forum rules.
    • Updated sticky-topic icon appearance and positioning, and adjusted borders and spacing in reply and topic-edit forms.
    • Consolidated screen-reader text styling with additional resets for consistent presentation.
    • Removed an earlier search-form positioning rule, changing how search forms are positioned.

CSS: Remove duplicate `:root, body` declarations and redundant selectors

- Remove redundant `:root, body` declarations.
- Deduplicate `#bbpress-forums fieldset.bbp-form legend` selector.
- Remove redundant `.bbpress #bbpress-forums .bbp-topics ul.sticky` rule.
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props timse201.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@timse201

timse201 commented Oct 2, 2026

Copy link
Copy Markdown
Author

A small first step

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d82f83e6-84c8-4c65-873d-2a02092f8817
📥 Commits

Reviewing files that changed from the base of the PR and between 3411f18 and 8d8e89f.

📒 Files selected for processing (1)
  • wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css
 ______________________________________________________________________
< If it “compiles on my machine”, I will make your machine my machine. >
 ----------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f9e4e909-3125-4461-a657-57839a9b84d1

📥 Commits

Reviewing files that changed from the base of the PR and between 2386a23 and 3411f18.

📒 Files selected for processing (1)
  • wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The support theme stylesheet removes repeated WordPress admin theme-color declarations, a redundant bbPress legend selector, and a bbPress sticky-topic background rule. The closing-brace line is replaced without changing the CSS rule structure.

Changes

Support theme stylesheet

Layer / File(s) Summary
Remove repeated declarations and bbPress rules
wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css
Removes repeated WordPress admin theme-color declarations, a redundant bbPress legend selector, and a bbPress sticky-topic background rule. The closing-brace line is replaced without changing the CSS rule structure.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 3411f

This cleanup preserves the admin theme colors, legend styling, and sticky-topic highlight. No change-specific issue remains to block merging.

Architecture Summary

Architecture risk: 🔵 Low · up to 3411f

The change affects 1 system.

Changed systems: wordpress.org

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — wordpress.org (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css: Removed the top-level :root, body declarations for the two WordPress admin theme-color variables.
  • observed — Modified behavior in wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css: Removed the redundant comma-terminated bbPress form legend selector; the following legend selector remains.
  • observed — Modified behavior in wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css: Removed two repeated :root, body declarations of the WordPress admin theme-color variables before the typography rules.
  • observed — Modified behavior in wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css: Removed a repeated :root, body declaration of the WordPress admin theme-color variables before the paragraph rules.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing duplicate CSS rules from Support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@timse201 timse201 added [Type] Enhancement New feature or request [Site] Forums labels Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

1 participant