Skip to content

Canonical: Short-circuit 404 template rendering for missing sourcemaps and admin assets - #14875

Open
robelsust wants to merge 1 commit into
WordPress:trunkfrom
robelsust:feature/66354-short-circuit-404-assets
Open

robelsust wants to merge 1 commit into
WordPress:trunkfrom
robelsust:feature/66354-short-circuit-404-assets

Conversation

@robelsust

Copy link
Copy Markdown

Description

Trac Ticket: https://core.trac.wordpress.org/ticket/66354

When a browser extension (such as React Developer Tools or Vue DevTools) or missing asset requests a .map sourcemap file (e.g. /wp-admin/installHook.js.map) or a missing asset within the administration or includes directory, server rewrite rules pass the request to index.php.

Because no post or page matches the path, WordPress flags is_404() = true and invokes the full 404 template loader. In block themes, this renders the theme canvas and executes render_block_core_template_part() for header and footer template parts, executing database queries, running transient caches, and returning invalid HTML for what should be a lightweight JSON sourcemap or asset 404.

Changes

  • Adds wp_short_circuit_404_assets(): bool in wp-includes/canonical.php.
  • Hooks wp_short_circuit_404_assets to template_redirect at priority 1010 in wp-includes/default-filters.php (running immediately after wp_redirect_admin_locations).
  • Immediately terminates 404 requests targeting .map files or paths inside admin_url() / includes_url() with a 404 status header and nocache headers.
  • Adds the wp_short_circuit_404_assets filter to allow plugins to customize or override the short-circuit behavior.
  • Adds dedicated unit tests in tests/phpunit/tests/canonical/shortCircuit404Assets.php.

Props @therssoftware, brumack

…s and admin assets.

When requests for missing sourcemaps (.map files) or assets within the admin or includes directories are routed to WordPress, the template loader previously rendered the full 404 theme template (including block templates, template parts, and database queries). This adds wp_short_circuit_404_assets() on template_redirect to terminate such requests with an immediate HTTP 404 status.

Props therssoftware, brumack.
Fixes #66354.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props therssoftware.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant