Repository navigation
Tests: Use assertWPError() in Customize nav menu item setting tests - #14571
shail-mehta wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The assertion replacement preserves existing test behavior and coverage, with no unresolved issues.
No open issues 🎉
What changed in this PR
Updates Customize nav menu item tests to use WordPress’s dedicated error assertion.
Changes:
- Replaces
assertInstanceOf( 'WP_Error', … )withassertWPError(). - Preserves the
invalid_urlerror-code check; no production code changes.
| File | Description |
|---|---|
tests/phpunit/tests/customize/nav-menu-item-setting.php |
Uses the dedicated assertion for invalid URL sanitization. |
Review effort: Balanced
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
lancewillett
left a comment
lancewillett
left a comment
There was a problem hiding this comment.
The assertion helper preserves the existing behavior and error checks. The affected suites pass locally in randomized single-site and multisite runs; the unit-test audit and PHPCS found no blockers.
AI review · gpt-6
Use `assertWPError()` when checking invalid URLs in the Customizer navigation menu item setting tests. Preserve the `invalid_url` error-code checks. Developed in: #14571 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64654 602fd350-edb4-49c9-b593-d223f7449a82
|
PR #14571 landed in https://core.trac.wordpress.org/changeset/64654 |
Use `assertWPError()` when checking invalid URLs in the Customizer navigation menu item setting tests. Preserve the `invalid_url` error-code checks. Developed in: WordPress/wordpress-develop#14571 Props shailu25. See #65819. Built from https://develop.svn.wordpress.org/trunk@64654 git-svn-id: http://core.svn.wordpress.org/trunk@63804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
What
Trac ticket: #65819
Replaces a generic
assertInstanceOf( 'WP_Error', … )assertion intests/phpunit/tests/customize/nav-menu-item-setting.phpwith WordPress’s dedicatedassertWPError()assertion.Retains the existing error code check.
Test-only change.
Why
Dedicated assertion methods improve failure reporting by including the
WP_Errorcode and message automatically.How
assertInstanceOf( 'WP_Error', … )call forassertWPError()in invalid URL sanitize coverageTesting instructions
Use of AI Tools