Skip to content

Code Quality: Annotate WP_HTML_Processor::next_token() as impure for PHPStan #14183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rejaulalomkhan wants to merge 2 commits into from
+2 −26
Closed

Code Quality: Annotate WP_HTML_Processor::next_token() as impure for PHPStan #14183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82288f6
Code Quality: Annotate WP_HTML_Processor::next_token() as impure for …
rejaulalomkhan Oct 11, 2026
f6ed4ba
Trigger CI
rejaulalomkhan Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ includes:
- tests/phpstan/baselines/booleanNot.alwaysFalse.neon
- tests/phpstan/baselines/booleanNot.alwaysTrue.neon
- tests/phpstan/baselines/booleanOr.alwaysFalse.neon
- tests/phpstan/baselines/booleanOr.alwaysTrue.neon
- tests/phpstan/baselines/class.notFound.neon
- tests/phpstan/baselines/deadCode.unreachable.neon
- tests/phpstan/baselines/empty.offset.neon
Expand Down
2 changes: 2 additions & 0 deletions src/wp-includes/html-api/class-wp-html-processor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,8 @@ public function next_tag( $query = null ): bool {
* @since 6.5.0 Added for internal support; do not use.
* @since 6.7.2 Refactored so subclasses may extend.
*
* @phpstan-impure
*
* @return bool Whether a token was parsed.
*/
public function next_token(): bool {
Expand Down
25 changes: 0 additions & 25 deletions tests/phpstan/baselines/booleanOr.alwaysTrue.neon
View file
Open in desktop

This file was deleted.

Loading