Skip to content

Media: Prevent drag and drop uploads in media states that don't support uploading - #14159

Open
nhrrob wants to merge 1 commit into
WordPress:trunkfrom
nhrrob:fix/47130-media-dropzone-states
Open

nhrrob wants to merge 1 commit into
WordPress:trunkfrom
nhrrob:fix/47130-media-dropzone-states

Conversation

@nhrrob

@nhrrob nhrrob commented Oct 10, 2026

Copy link
Copy Markdown

Stops the media modal's "Drop files to upload" overlay and drag-and-drop uploads in states that aren't for uploading (crop, edit image, image/audio/video details, insert from URL), via a new uploader: false state attribute.

Testing instructions

  1. Go to Settings > General > Site Icon, choose an image larger than 512×512 and click "Set as Site Icon" to reach the Crop step.
  2. Drag a file from your computer over the modal.
  3. Before: the "Drop files to upload" overlay appears and dropping uploads the file. After: no overlay and nothing is uploaded.
  4. Close the modal, open it again and drag a file onto the Media Library tab: it still uploads as before.
  5. Optionally repeat steps 1–3 in Appearance > Customize > Site Identity > Site Icon.

Trac ticket: https://core.trac.wordpress.org/ticket/47130

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the change and verifying it with Playwright; reviewed and tested by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…rt uploading.

The "Drop files to upload" overlay and drag and drop uploads were active in
every media modal state, including ones unrelated to uploading such as
cropping or editing an image. Dropping a file there uploaded it to the
library behind the current task.

Introduce an `uploader` state attribute: when set to false, the uploader
window ignores files dragged onto the modal. Set it for the cropper, edit
image, image/audio/video details, and embed states.

See #47130.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nhrrob.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant