Repository navigation
Tests: Assert matched route for edit site export OPTIONS checks. - #14147
Closed
shail-mehta wants to merge 1 commit into
Closed
shail-mehta wants to merge 1 commit into
shail-mehta wants to merge 1 commit into
Conversation
Strengthen the OPTIONS probes in update/delete negatives so a default 200 without a real route match would fail. Follow-up to [64275]. See #66073.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
lancewillett
approved these changes
Oct 10, 2026
Member
|
PR #14147 landed in https://core.trac.wordpress.org/changeset/64281 |
wporg-sync
pushed a commit
that referenced
this pull request
Oct 10, 2026
Assert that the OPTIONS responses match the expected export route before checking unsupported update and delete methods. A successful status alone does not establish that a route matched. Developed in: #14147 Props shailu25. See #66073. git-svn-id: https://develop.svn.wordpress.org/trunk@64281 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Oct 10, 2026
Assert that the OPTIONS responses match the expected export route before checking unsupported update and delete methods. A successful status alone does not establish that a route matched. Developed in: WordPress/wordpress-develop#14147 Props shailu25. See #66073. Built from https://develop.svn.wordpress.org/trunk@64281 git-svn-id: http://core.svn.wordpress.org/trunk@63431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #66073
Follow-up to: #14115
What
Strengthens the OPTIONS probes in
Tests_REST_WpRestEditSiteExportController::test_update_item()andtest_delete_item()by also asserting the matched route.Updated file:
tests/phpunit/tests/rest-api/wpRestEditSiteExportController.phpWhy
rest_handle_options_request()can return a default200even when no route matches, so status alone does not prove the export route exists. Asserting$response->get_matched_route()makes that check reliable. The existing route-registration test already covers registration; this is a small strengthening of the update/delete negatives.How
assertSame( 200, $response->get_status() ), addassertSame( $route, $response->get_matched_route() )in bothtest_update_item()andtest_delete_item()Testing instructions
npm run test:php -- --filter Tests_REST_WpRestEditSiteExportControllerUse of AI tools
Cursor