Skip to content

Build/Test Tools: Remove the unused check-node-version dependency. - #14127

Open
mukeshpanchal27 wants to merge 2 commits into
WordPress:trunkfrom
mukeshpanchal27:deps/remove-check-node-version
Open

mukeshpanchal27 wants to merge 2 commits into
WordPress:trunkfrom
mukeshpanchal27:deps/remove-check-node-version

Conversation

@mukeshpanchal27

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/65857

check-node-version is listed in the root devDependencies, but nothing in core uses it. No npm script, Grunt task, file under tools/ or GitHub Actions workflow refers to it.

r43321 added the package to check the installed Node.js and npm versions. The next changeset, r43322, removed that check because it threw errors. The dependency stayed and kept receiving version bumps. Node.js versions are now managed through .nvmrc.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Checking the dependency history and usage, making the change, and writing the commit message and this description. The work was done under my direction.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

The package was added in [43321] to check the installed Node.js and npm versions. [43322] removed the check because it threw errors, but the dependency stayed and kept receiving version bumps.

Nothing in core uses it now. Node.js versions are managed through `.nvmrc`. The package remains installed as a dependency of `@wordpress/scripts`, which uses it for its `check-engines` command.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27 mukeshpanchal27 self-assigned this Oct 9, 2026
@mukeshpanchal27
mukeshpanchal27 marked this pull request as ready for review October 9, 2026 04:23
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow dependency removal is consistent across both files, with no unresolved findings.

0 open findings

What changed in this PR

Removes an unused build dependency from WordPress Core’s root npm configuration.

Changes:

  • Removes check-node-version from the development dependencies and the lockfile’s root dependency list.
File Description
package.json Removes the direct development dependency.
package-lock.json Keeps the root lockfile dependencies in sync.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants