Repository navigation
Build/Test Tools: Remove the unused check-node-version dependency. - #14127
mukeshpanchal27 wants to merge 2 commits into
Conversation
The package was added in [43321] to check the installed Node.js and npm versions. [43322] removed the check because it threw errors, but the dependency stayed and kept receiving version bumps. Nothing in core uses it now. Node.js versions are managed through `.nvmrc`. The package remains installed as a dependency of `@wordpress/scripts`, which uses it for its `check-engines` command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
🟢 Approval recommended
The narrow dependency removal is consistent across both files, with no unresolved findings.
0 open findings
What changed in this PR
Removes an unused build dependency from WordPress Core’s root npm configuration.
Changes:
- Removes
check-node-versionfrom the development dependencies and the lockfile’s root dependency list.
| File | Description |
|---|---|
| package.json | Removes the direct development dependency. |
| package-lock.json | Keeps the root lockfile dependencies in sync. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Trac ticket: https://core.trac.wordpress.org/ticket/65857
check-node-versionis listed in the rootdevDependencies, but nothing in core uses it. No npm script, Grunt task, file undertools/or GitHub Actions workflow refers to it.r43321 added the package to check the installed Node.js and npm versions. The next changeset, r43322, removed that check because it threw errors. The dependency stayed and kept receiving version bumps. Node.js versions are now managed through
.nvmrc.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Checking the dependency history and usage, making the change, and writing the commit message and this description. The work was done under my direction.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.