Repository navigation
Tests: Assert unsupported requests for font collections controller - #14116
Open
shail-mehta wants to merge 1 commit into
Open
shail-mehta wants to merge 1 commit into
shail-mehta wants to merge 1 commit into
Conversation
shail-mehta
force-pushed
the
tests/66073-font-collections-negative-assertions
branch
from
October 8, 2026 17:45
ba4edc1 to
af0aea3
Compare
shail-mehta
marked this pull request as ready for review
October 8, 2026 18:11
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #66073
What
Replaces empty
@doesNotPerformAssertionscreate/update/delete stubs inTests_REST_WpRestFontCollectionsControllerwith real negative assertions.Each unsupported request asserts
rest_no_routewith status404, using an authenticated administrator and a valid item fixture (mock-col-slug).Updated file:
tests/phpunit/tests/fonts/font-library/wpRestFontCollectionsController.phpWhy
The font collections controller only registers readable collection and item routes. Empty abstract-method stubs hide whether unsupported write operations are actually rejected, and the annotation count keeps growing.
This continues the agreed approach from [64004] / [64075] / [64076] on another conventional read-only controller, before any broader
WP_Test_REST_Controller_Testcasechange.How
POST /wp/v2/font-collections→rest_no_route/404(collection is GET-only)POST/PUT/PATCH/wp/v2/font-collections/mock-col-slug→rest_no_route/404(item is GET-only; asserts GET 200 first so the path is proven valid)DELETE /wp/v2/font-collections/mock-col-slug→rest_no_route/404(asserts GET 200 first)prepare_item()unchanged (held for further discussion)Testing instructions
npm run test:php -- --filter Tests_REST_WpRestFontCollectionsControllerUse of AI tools
Cursor