Skip to content

Code Quality: Improve PHPStan types in l10n.php #14079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
westonruter wants to merge 8 commits into from
Closed

Code Quality: Improve PHPStan types in l10n.php #14079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
173f943
Require literal strings for gettext function arguments
westonruter Oct 7, 2026
681fc27
Narrow word count type return to its three valid values
westonruter Oct 7, 2026
26bafd2
Specify the return type of wp_get_installed_translations()
westonruter Oct 7, 2026
8a5fbd5
Return a fixed header shape from the translation file data functions
westonruter Oct 7, 2026
58a2089
Use string-keyed array types for translation file headers
westonruter Oct 7, 2026
0f1c6b8
Include WP_Translations in get_translations_for_domain() return type
westonruter Oct 7, 2026
8502266
Correct the types of the $l10n and $l10n_unloaded globals
westonruter Oct 7, 2026
5577b20
Remove inline @var tags made redundant by @global tags
westonruter Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/wp-includes/class-wp-locale.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,8 @@ public function get_list_item_separator() {
*
* @return string Localized word count type. Possible values are `characters_excluding_spaces`,
* `characters_including_spaces`, or `words`. Defaults to `words`.
*
* @phpstan-return 'characters_excluding_spaces'|'characters_including_spaces'|'words'
*/
public function get_word_count_type() {

Expand Down
Loading
Loading