Repository navigation
Conversation
An empty `default` on an object schema is sent to clients as `{}`.
Other defaults stay unchanged.
See #64955.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a test for how
wp_prepare_json_schema_for_client()handles thedefaultof a schema. It uses a data provider with three cases:defaulton an object schema is encoded as{}.defaulton an object schema stays the same.defaulton an array schema stays[].Why?
In PHP, an empty array is encoded as
[]in JSON. For an object schema, clients expect{}. The helper already fixes this, but only a nested property was tested before, not the root schema.Abilities rely on this. They can use
'default' => array()in an object input schema, and both the REST API and the AI client still send{}. This came up in #12141.Testing
Trac ticket: https://core.trac.wordpress.org/ticket/64955
Use of AI Tools
The test and this description were drafted with Claude Code and reviewed by me.
🤖 Generated with Claude Code