Build/QA: Retire booleanOr.alwaysTrue PHPStan baseline

[huzaifaalmesbah]

Description

Retires the booleanOr.alwaysTrue PHPStan baseline in WordPress core by annotating WP_HTML_Processor::next_token() with @phpstan-impure.

WP_HTML_Processor::next_token() advances the HTML processor state and yields different tokens on consecutive calls. Without the @phpstan-impure annotation, PHPStan's purity inference assumed that successive calls inside iteration or boolean expressions would produce identical results. This caused PHPStan to flag || expressions as always true in callers like WP_Block::replace_html().

Adding @phpstan-impure accurately conveys the state mutation to PHPStan, which eliminates false positive purity assumptions across the codebase, resolves associated errors in booleanNot.alwaysTrue and deadCode.unreachable, and completely retires booleanOr.alwaysTrue.neon.

Testing Instructions

1. Run static analysis:

   composer phpstan

   Confirm 0 errors are found and booleanOr.alwaysTrue.neon is no longer needed.

2. Run PHPCS:

   vendor/bin/phpcs src/wp-includes/html-api/class-wp-html-processor.php

   Confirm standards compliance.

Trac ticket: https://core.trac.wordpress.org/ticket/65817

Use of AI Tools

AI assistance: Yes
Tool(s): Google Antigravity
Model(s): Gemini 3.8 Flash
Used for: Researching static analysis reports and drafting initial baseline diffs; all logic, type declarations, and analysis results were manually investigated, verified, and run locally by me.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.