Repository navigation
Bundled Themes: Add devEngines to themes with a build process - #13656
Closed
manzoorwanijk wants to merge 1 commit into
Closed
manzoorwanijk wants to merge 1 commit into
manzoorwanijk wants to merge 1 commit into
Conversation
Mirrors the root `package.json` so the Node.js and npm requirements are enforced in Twenty Twenty-One, Twenty Twenty-Two and Twenty Twenty-Five.
Member
Author
manzoorwanijk
marked this pull request as ready for review
September 22, 2026 11:32
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
lucatume
approved these changes
Sep 22, 2026
Member
wporg-sync
pushed a commit
that referenced
this pull request
Sep 22, 2026
Add Core's devEngines configuration to Twenty Twenty-One, Twenty Twenty-Two, and Twenty Twenty-Five. Enforce their existing Node.js and npm minimum versions when installing dependencies or running npm scripts, and let the shared setup-npm action select a compatible npm version for each theme. Follow-up to [63782]. Developed in: #13656 Props manzoorwanijk, lucatume. See #66099. git-svn-id: https://develop.svn.wordpress.org/trunk@63870 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Sep 22, 2026
Add Core's devEngines configuration to Twenty Twenty-One, Twenty Twenty-Two, and Twenty Twenty-Five. Enforce their existing Node.js and npm minimum versions when installing dependencies or running npm scripts, and let the shared setup-npm action select a compatible npm version for each theme. Follow-up to [63782]. Developed in: WordPress/wordpress-develop#13656 Props manzoorwanijk, lucatume. See #66099. Built from https://develop.svn.wordpress.org/trunk@63870 git-svn-id: http://core.svn.wordpress.org/trunk@63042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
devEnginesblock from the root package.json to Twenty Twenty-One, Twenty Twenty-Two and Twenty Twenty-Five for consistency with Core. WithonFail: "error", npm refuses to install when the Node.js or npm version is below whatenginesalready declares. Versions match trunk (Node.js>=24.18.0, npm>=11.16.0), and the lockfiles are unchanged.Follow-up to #13505.
Extracted from #13536
Trac ticket: https://core.trac.wordpress.org/ticket/66099
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Implementation and this description, reviewed by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code