Skip to content

Block Bindings: Add icon attribute of core/icon block to list of supported block binding attributes - #12708

Closed
yashjawale wants to merge 11 commits into
WordPress:trunkfrom
yashjawale:feat/icon-block-pattern-overrides
Closed

Block Bindings: Add icon attribute of core/icon block to list of supported block binding attributes#12708
yashjawale wants to merge 11 commits into
WordPress:trunkfrom
yashjawale:feat/icon-block-pattern-overrides

Conversation

@yashjawale

@yashjawale yashjawale commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown

This PR adds icon attribute of core/icon block to the list of supported block binding attributes.

Trac ticket: https://core.trac.wordpress.org/ticket/65725

Use of AI Tools

Test case authored with DeepSeek V4 Flash via Opencode.
All changes reviewed & tested manually.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copilot AI review requested due to automatic review settings July 27, 2026 08:57
@github-actions

github-actions Bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props yashjawale, wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot AI reviewed Jul 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the block bindings allowlist to support binding the icon attribute on the core/icon block, enabling block bindings sources to populate the icon selection.

Changes:

  • Add core/icon to the supported block binding attributes map with support for the icon attribute.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/wp-includes/block-bindings.php
Copilot AI review requested due to automatic review settings July 27, 2026 11:02
Copilot AI reviewed Jul 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread tests/phpunit/tests/block-bindings/render.php Outdated
Comment thread src/wp-includes/block-bindings.php
Comment thread tests/phpunit/tests/block-bindings/render.php
Comment thread tests/phpunit/tests/block-bindings/render.php Outdated
@yashjawale
fix: issue number in docblock comment
6fe8466
@yashjawale
docs: update docblock to include @SInCE tag
2e736aa
@yashjawale
test: make Icon block binding test use self-contained icon collection
efda743 
Use a test-specific icon collection instead of depending on the core
collection, which may be unregistered by other test suites running
in the same process.
@yashjawale
fix: wrap test in try/catch block
83cafe3
Copilot AI review requested due to automatic review settings July 27, 2026 11:15
Copilot AI reviewed Jul 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread tests/phpunit/tests/block-bindings/render.php
Comment thread src/wp-includes/block-bindings.php Outdated
@yashjawale
fix: typo in docblock
8695b62 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 27, 2026 11:23
Copilot AI reviewed Jul 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

t-hamano
t-hamano reviewed Oct 7, 2026
View reviewed changes
Comment thread src/wp-includes/block-bindings.php Outdated
yashjawale and others added 2 commits October 7, 2026 13:17
@yashjawale @t-hamano
docs: update since comment to refer 7.2
fd64cc0 
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
@yashjawale
Merge branch 'trunk' into feat/icon-block-pattern-overrides
6f89b39
t-hamano
t-hamano approved these changes Oct 7, 2026
View reviewed changes

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions Bot mentioned this pull request Oct 7, 2026
Open
wporg-sync pushed a commit that referenced this pull request Oct 7, 2026
@t-hamano
Block Bindings: Add support for Icon block's icon attribute.
702a0d0 
Enable Block Bindings support for the Icon block's `icon` attribute, so the displayed icon can be supplied by a block bindings source. This also makes pattern overrides available for the Icon block.

Developed in: #12708

Props wildworks, yashjawale.
Fixes #65725.


git-svn-id: https://develop.svn.wordpress.org/trunk@64225 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 64225
GitHub commit: 702a0d0

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Oct 7, 2026
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 7, 2026
@t-hamano
Block Bindings: Add support for Icon block's icon attribute.
ff5bb7b 
Enable Block Bindings support for the Icon block's `icon` attribute, so the displayed icon can be supplied by a block bindings source. This also makes pattern overrides available for the Icon block.

Developed in: WordPress/wordpress-develop#12708

Props wildworks, yashjawale.
Fixes #65725.

Built from https://develop.svn.wordpress.org/trunk@64225


git-svn-id: http://core.svn.wordpress.org/trunk@63376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@t-hamano t-hamano t-hamano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yashjawale @t-hamano