Skip to content

Follow the bundled theme conventions - #157

Merged
MaggieCabrera merged 1 commit into
trunkfrom
claude/bundled-theme-conventions
Oct 20, 2026
Merged

MaggieCabrera merged 1 commit into
trunkfrom
claude/bundled-theme-conventions

Conversation

@MaggieCabrera

Copy link
Copy Markdown
Contributor

Description

Brings the bundled theme conventions from the core import (WordPress/wordpress-develop#14558) back to this repo, so the next sync to core doesn't undo them. See #66352.

  • Version: 1.0 and Tested up to: 7.2, like Twenty Twenty-Two to Twenty Twenty-Five.
  • The readme gets the === Ipsum === title and a = 1.0 = changelog entry with the release date and the changelog article link.
  • Every file ends with a newline, as core's .editorconfig asks. The block markup itself is untouched.

The theme files now match the core copy byte for byte. The README and the bug report template now say the version stays at 1.0 during development.

Testing Instructions

  1. Run npm run lint. It passes.
  2. Activate Ipsum. Appearance → Themes shows version 1.0, and Theme Check gives the same result as on trunk.
  3. Check the front end and the Site Editor with the default colors and Evening. Both render as expected, with no block warnings.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Applying the changes from the core commit, checking them against core, and running the linters and checks. I reviewed the diff.

🤖 Generated with Claude Code

Sets the version to 1.0 and "Tested up to" to 7.2, uses the `=== Name ===` readme title and the release changelog entry of the other bundled themes, and ends every file with a newline. These match the core import, so the next sync to core doesn't undo them.

See https://core.trac.wordpress.org/ticket/66352.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation [Type] Tooling Issues or PRs related to tooling [Area] Template Parts Issues or PRs that touch the theme's template parts (header, footer, etc). [Area] Templates Issues or PRs that touch the theme's block templates. [Area] Global Styles Issues or PRs that touch theme.json or the base stylesheet. [Area] Patterns Issues or PRs that touch the theme's block patterns. labels Oct 20, 2026
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@MaggieCabrera

Copy link
Copy Markdown
Contributor Author

since this are PHPCS changes I'm committing this without review

@MaggieCabrera
MaggieCabrera merged commit fd9610b into trunk Oct 20, 2026
7 checks passed
@MaggieCabrera
MaggieCabrera deleted the claude/bundled-theme-conventions branch October 20, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Global Styles Issues or PRs that touch theme.json or the base stylesheet. [Area] Patterns Issues or PRs that touch the theme's block patterns. [Area] Template Parts Issues or PRs that touch the theme's template parts (header, footer, etc). [Area] Templates Issues or PRs that touch the theme's block templates. documentation Improvements or additions to documentation [Type] Tooling Issues or PRs related to tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant