Repository navigation
Conversation
Keep the essential Trac #63568 fix — escape uploaded font family names into CSS values at the client/server boundary (createCssString) and separate the display name from the CSS value — while restoring the FontFace-API-based font loading from trunk instead of rewriting it onto constructed stylesheets. Stored escaped values are decoded back to plain family names inside formatFontFaceName, the single choke point both loadFontFaceInBrowser and unloadFontFaceInBrowser already flow through, so load and unload matching stay consistent for escaped and legacy raw values alike. createCssString escapes every character outside [A-Za-z0-9_-]/non-ASCII with terminator-less six-digit escapes, making the value a verified fixed point of WP_Font_Utils::sanitize_font_family() and a valid unquoted identifier sequence (core strips the surrounding quotes when printing @font-face rules). Also splits the package tsconfig into build and dev projects so test files and jest types stay out of the published build-types.
sirreal
added
the
[Type] Task
github-actions
Bot
added
[Package] Editor
|
Size Change: -246 B (0%) Total Size: 7.73 MB 📦 View Changed
|
sirreal
force-pushed
the
trac-63568/uploaded-font-name-minimal-v2
branch
from
August 19, 2026 03:49
10c92a6 to
7cd9b4b
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
Bot
removed
[Package] Editor
sirreal
force-pushed
the
trac-63568/uploaded-font-name-minimal-v2
branch
from
August 19, 2026 03:57
7cd9b4b to
10c92a6
Compare
github-actions
Bot
added
[Package] Editor
# Conflicts: # packages/global-styles-ui/tsconfig.json
sirreal
requested review from
a team,
adamsilverstein,
ajitbohra,
ellatrix,
fabiankaegy,
gigitux,
juanmaguitar,
manzoorwanijk,
ntsekouras,
ntwb,
oandregal,
retrofox,
spacedmonkey and
talldan
as code owners
August 19, 2026 04:09
github-actions
Bot
added
[Package] Server Side Render
github-actions
Bot
removed
[Package] Core data
sirreal
marked this pull request as draft
August 19, 2026 04:18
sirreal
changed the base branch from
trac-63568/uploaded-font-name-minimal-fix
to
trunk
August 19, 2026 04:18
sirreal
changed the base branch from
trunk
to
trac-63568/uploaded-font-name-minimal-fix
August 19, 2026 04:18
sirreal
removed request for
a team,
adamsilverstein,
ajitbohra,
ellatrix,
gigitux,
juanmaguitar,
ntsekouras,
ntwb,
oandregal,
retrofox,
spacedmonkey and
talldan
August 19, 2026 04:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the essential Trac 63568 fix — escape uploaded font family names into CSS values at the client/server boundary (createCssString) and separate the display name from the CSS value — while restoring the FontFace-API-based font loading from trunk instead of rewriting it onto constructed stylesheets.
Stored escaped values are decoded back to plain family names inside formatFontFaceName, the single choke point both loadFontFaceInBrowser and unloadFontFaceInBrowser already flow through, so load and unload matching stay consistent for escaped and legacy raw values alike.
Targets #76782