Description
Discovered while tedsting Core WordPress/wordpress-develop#13348
This is a blocker for Core-66015 and should be addressed soon, please.
Can we please make sure this fix will be part of the changes for WordPress 7.1.1?
cc @adamsilverstein @adrianduffell @andreiglingeanu
In the Connectors page, the list of connectors uses a VStack component with a hardcoded role='list'.
When using a role='list' all children must have a role='listitem'.
The missing listitem role is caught by the Axe-core automated checks we want to introduce in Core and reported as a violation.
Either the hardcoded role='list' should be removed or [the ConnectorItem component](https://github.com/WordPress/gutenberg/blob/0eaf6c57c664895b52508eb1c96ff2d6336cbb63/routes/connectors-home/default-connectors.tsx#L226) should have a role='listitem'`.
For the future, it is important to note that any piece of UI added into the list of connectors must be a listitem.
Note:
I can't see a GitHub label for packages/connectors or routes.
Step-by-step reproduction instructions
N/A
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Please confirm which theme type you used for testing.
Description
Discovered while tedsting Core WordPress/wordpress-develop#13348
This is a blocker for Core-66015 and should be addressed soon, please.
Can we please make sure this fix will be part of the changes for WordPress 7.1.1?
cc @adamsilverstein @adrianduffell @andreiglingeanu
In the Connectors page, the list of connectors uses a VStack component with a hardcoded role='list'.
When using a
role='list'all children must have arole='listitem'.The missing listitem role is caught by the Axe-core automated checks we want to introduce in Core and reported as a violation.
Either the hardcoded
role='list' should be removed or [the ConnectorItem component](https://github.com/WordPress/gutenberg/blob/0eaf6c57c664895b52508eb1c96ff2d6336cbb63/routes/connectors-home/default-connectors.tsx#L226) should have arole='listitem'`.For the future, it is important to note that any piece of UI added into the list of connectors must be a listitem.
Note:
I can't see a GitHub label for
packages/connectorsorroutes.Step-by-step reproduction instructions
N/A
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Please confirm which theme type you used for testing.