Skip to content

Add Update URI protection to generated themes - #876

Open
thetwopct wants to merge 1 commit into
WordPress:trunkfrom
thetwopct:fix/generated-theme-update-uri
Open

thetwopct wants to merge 1 commit into
WordPress:trunkfrom
thetwopct:fix/generated-theme-update-uri

Conversation

@thetwopct

Copy link
Copy Markdown

Summary

  • add Update URI: false to every newly generated clone, blank theme, and child theme
  • preserve an existing Update URI when CBT updates metadata for an existing theme
  • add regression coverage for generated and existing theme stylesheets

This prevents a custom theme created with CBT from being replaced by an unrelated WordPress.org theme when their slugs collide.

Closes #875.

Testing

  • ./vendor/bin/phpcs --standard=phpcs.xml.dist
  • targeted PHPUnit suite: 4 tests, 5 assertions passed
  • isolated API and font tests implicated by the full-suite run: 6 tests, 24 assertions passed
  • JavaScript unit tests: 15 tests passed
  • JavaScript, CSS, Markdown, and package JSON linters passed
  • production build passed with existing dependency, Sass, icon, and bundle-size warnings

The complete PHP suite currently reports six order-dependent failures in existing API and font tests; all six pass when run in isolation. The new stylesheet test suite passes both independently and as part of the complete run.

@thetwopct
thetwopct force-pushed the fix/generated-theme-update-uri branch from fe95537 to 31f4955 Compare October 2, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Update URI: false to generated themes to prevent WordPress.org slug collisions

1 participant