Update Kraków UHI dataset implementation - #154
Open
wkravchyk wants to merge 4 commits into
Open
Conversation
| self, | ||
| data_dir: str, | ||
| modalities: dict, | ||
| use_unlabelled_data: bool = False, |
Contributor
There was a problem hiding this comment.
This is only relevant to the butterfly UC, because there we obtain more data, which do not have prediction labels.
Contributor
Author
There was a problem hiding this comment.
That's clear, I added this parameter to keep compatibility with experiment tracker. It is probably better to remove it from here and replace it with **kwargs, and in config files put use_unlabelled_data: false flag.
Contributor
There was a problem hiding this comment.
Yes, also you can just delete this argument from the dataset class and config file (e.g, see SatBird use case https://github.com/WUR-AI/aether/tree/train/satbird_pred )
gabrieletijunaityte
requested changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces three main updates to the Kraków UHI dataset implementation:
src/data/heat_krakow_dataset.pyto the changes introduced in the PRs Organise dataset #124 and Transfer updates from BaseDataset and BaseCaption builder to the UC dataset implementations #125,src/data/heat_krakow_caption_builder.py) together with concept and location captions, since they were missing,configs/data/heat_krakow_tessera_text.yamlconfigs/model/heat_krakow_fusion_alignment.yaml,configs/experiment/krakow/heat_krakow_alignment.yamlBefore submitting
pytestcommand?