refactor: scoped state writes preserve untouched entries#22
Open
dhruva-reddy wants to merge 1 commit intodhruva-reddy/feat/snapshot-rollbackfrom
Open
refactor: scoped state writes preserve untouched entries#22dhruva-reddy wants to merge 1 commit intodhruva-reddy/feat/snapshot-rollbackfrom
dhruva-reddy wants to merge 1 commit intodhruva-reddy/feat/snapshot-rollbackfrom
Conversation
This was referenced May 1, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fdf7bfb to
c916a21
Compare
6ebaebb to
90d7cd0
Compare
c916a21 to
34ae2cb
Compare
90d7cd0 to
1b79bc3
Compare
34ae2cb to
9667011
Compare
1b79bc3 to
0aa2c59
Compare
9667011 to
866b910
Compare
## ELI5 **Problem.** Even when you ran a *scoped* push — say `npm run push -- <env> assistants/foo.md` to update one assistant — the engine rewrote the **entire** state file. Any pre-existing drift in unrelated state entries (UUIDs from earlier sessions, untracked local files, etc.) swept into the focused commit. Reviewers couldn't tell from the state-file diff "what did this push actually change?" and the state file became a pile of side effects accumulated across sessions instead of a precise record of intent. **What this fix does.** During a push, the engine tracks which `resourceId`s it actually mutated (a per-section `Set<string>`). At end-of-run, for **scoped pushes only**, it loads the on-disk state fresh, replaces only the touched entries with the in-memory version, and leaves everything else alone. Full pushes (no scope) still write wholesale (existing behavior). Credentials are always replaced because bootstrap pull populates them every push regardless. This depends on Stack F's `ResourceState` because we need per-entry metadata to distinguish "stale" from "just-not-touched." **Outcome you'll notice.** A one-file `npm run push` produces a one-file diff in the state file — same scope as the resource change. Reviewers can read the state diff and tell "this push updated assistant `foo`, here's its new hash" cleanly. Pre-existing drift elsewhere in state stays where it is until you explicitly address it. --- When push is scoped to specific paths, only update state entries for the resources actually touched. A surgical push of two files used to rewrite the entire state file, sweeping in pre-existing drift from earlier pushes (improvements.md #15) and producing noisy diffs that hide the actual scope of the change. Files: - src/state-merge.ts (NEW): mergeScoped(disk, inMemory, touched). For each section, replace only touched.X resourceIds with the in-memory version; leave the rest of disk's section as-is. Credentials are always replaced wholesale (bootstrap pull populates them on every push). Pure data, no I/O — safe to test directly. - src/push.ts: TouchedSets tracker. Each upsertState call site records the resourceId. End-of-run, partial pushes call mergeScoped(loadState(), state, touched) before saveState; full pushes save wholesale (existing behavior). - tests/state-merge.test.ts: replace-only-touched, leave-untouched, drift in untouched stays, credentials always replaced. Closes improvements.md #15. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
0aa2c59 to
259746d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ELI5
Problem. Even when you ran a scoped push — say
npm run push -- <env> assistants/foo.mdto update one assistant —the engine rewrote the entire state file. Any pre-existing drift
in unrelated state entries (UUIDs from earlier sessions, untracked
local files, etc.) swept into the focused commit. Reviewers couldn't
tell from the state-file diff "what did this push actually change?"
and the state file became a pile of side effects accumulated across
sessions instead of a precise record of intent.
What this fix does. During a push, the engine tracks which
resourceIds it actually mutated (a per-sectionSet<string>). Atend-of-run, for scoped pushes only, it loads the on-disk state
fresh, replaces only the touched entries with the in-memory version,
and leaves everything else alone. Full pushes (no scope) still write
wholesale (existing behavior). Credentials are always replaced
because bootstrap pull populates them every push regardless.
This depends on Stack F's
ResourceStatebecause we need per-entrymetadata to distinguish "stale" from "just-not-touched."
Outcome you'll notice. A one-file
npm run pushproduces aone-file diff in the state file — same scope as the resource change.
Reviewers can read the state diff and tell "this push updated
assistant
foo, here's its new hash" cleanly. Pre-existing driftelsewhere in state stays where it is until you explicitly address it.
When push is scoped to specific paths, only update state entries for
the resources actually touched. A surgical push of two files used to
rewrite the entire state file, sweeping in pre-existing drift from
earlier pushes (improvements.md #15) and producing noisy diffs that
hide the actual scope of the change.
Files:
For each section, replace only touched.X resourceIds with the in-memory
version; leave the rest of disk's section as-is. Credentials are
always replaced wholesale (bootstrap pull populates them on every
push). Pure data, no I/O — safe to test directly.
records the resourceId. End-of-run, partial pushes call
mergeScoped(loadState(), state, touched) before saveState; full
pushes save wholesale (existing behavior).
drift in untouched stays, credentials always replaced.
Closes improvements.md #15.
🤖 Generated with Claude Code