Skip to content

fix(cleaners): avoid UnboundLocalError in _get_indexed_match when the pattern is absent #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eeshsaxena wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

fix(cleaners): avoid UnboundLocalError in _get_indexed_match when the pattern is absent #4429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5553104
fix(cleaners): avoid UnboundLocalError in _get_indexed_match when pat…
eeshsaxena Aug 8, 2026
8670e4f
fix(cleaners): initialize loop counter and guard the not-found message
eeshsaxena Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion unstructured/cleaners/extract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,16 @@ def _get_indexed_match(text: str, pattern: str, index: int = 0) -> re.Match:
raise ValueError(f"The index is {index}. Index must be a non-negative integer.")

regex_match = None
i = -1

@cubic-dev-ai cubic-dev-ai Bot Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The fix is correct, but it ships without a regression test for the exact crash it repairs — the PR's own repro extract_text_before("hello world", "xyz") would currently raise UnboundLocalError, and neither existing test in test_extract.py exercises the pattern-absent path. Please add a test asserting the pattern-absent case raises ValueError (not UnboundLocalError) and that the message omits the 'largest index' detail when there are no matches, so this fix doesn't silently regress.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At unstructured/cleaners/extract.py, line 21:

<comment>The fix is correct, but it ships without a regression test for the exact crash it repairs — the PR's own repro `extract_text_before("hello world", "xyz")` would currently raise UnboundLocalError, and neither existing test in test_extract.py exercises the pattern-absent path. Please add a test asserting the pattern-absent case raises ValueError (not UnboundLocalError) and that the message omits the 'largest index' detail when there are no matches, so this fix doesn't silently regress.</comment>

<file context>
@@ -18,12 +18,16 @@ def _get_indexed_match(text: str, pattern: str, index: int = 0) -> re.Match:
         raise ValueError(f"The index is {index}. Index must be a non-negative integer.")
 
     regex_match = None
+    i = -1
     for i, result in enumerate(re.finditer(pattern, text)):
         if i == index:
</file context>

for i, result in enumerate(re.finditer(pattern, text)):
if i == index:
regex_match = result

if regex_match is None:
raise ValueError(f"Result with index {index} was not found. The largest index was {i}.")
message = f"Result with index {index} was not found."
if i >= 0:
message += f" The largest index was {i}."
raise ValueError(message)

return regex_match

Expand Down