Moved update_gddlai subroutine into new module file for lai calculations

[MatthewPaskin]

No description provided.

[github-actions]

CI Build Plan

Changed Files

Fortran source (3 files)

• src/suews/Makefile
• src/suews/src/suews_phys_dailystate.f95
• src/suews/src/suews_phys_lai.f95

Build system (1 file)

• src/supy/meson.build

Build Configuration

	Configuration
Platforms	Linux x86_64, macOS ARM64, Windows x64
Python	3.12
Test tier	standard (non-slow + core physics regressions)
PR status	Ready (standard matrix)

Rationale

• Fortran source changed -> multiplatform build required
• Build system changed -> multiplatform build required

---

_{Updated by CI on each push. See path-filters.yml for category definitions.}

[sunt05]

Hi @MatthewPaskin — CI is green here and it merges cleanly, but the 4-in-progress label is still on. Is this ready for review, or still in flight?

[MatthewPaskin]

@sunt05 This PR was simply intended as base to be expanded with further ideas to migrate LAI related code to a new file. Currently only the recent refactored code is stored here, largely because of the change in style compared to the rest of the daily state file, therefore separating the styles for maintainability.

That said, I don't have time to move any other code to this file at this time and other branches that expand the LAI/GDD behaviour have been built upon this branch and I think it is a worthy merge in its current state.

I will mark it for review. Thanks!

[sunt05]

Thanks Matthew, this is a clean lift. I have reviewed it against master and the only changes are the renames, crit_days promoted to module scope, and the three LAI calculations turned into functions, so no physics moves. CI agrees: the full test_laimethod.py suite and the full-year sample-output comparison are green.

Merging now. A few bits of tidying came out of the review and are in #1811, none of which needed to hold this up.