Currently the vegetation input parameters gdd_full and sdd_full can be set lower than the hard coded critdays value of 50 (applied as -50 for SDD). In this case the conditions on critdays never apply.
This is not necessarily a problem but raising an issue for discussion and investigation into this. Given that critdays is also currently a magic number, this could be cleaned generally and/or brought outside the Fortran as a model parameter.
Currently the vegetation input parameters gdd_full and sdd_full can be set lower than the hard coded critdays value of 50 (applied as -50 for SDD). In this case the conditions on critdays never apply.
This is not necessarily a problem but raising an issue for discussion and investigation into this. Given that critdays is also currently a magic number, this could be cleaned generally and/or brought outside the Fortran as a model parameter.