Improve Logging - #670
Open
tabassom-entezami wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The primary reason to pass variables as arguments using %s rather than embedding them directly in an f-string is to utilize lazy evaluation. By passing the template and the variable separately, the logging module only spends computational resources constructing the final string if that specific log level is currently enabled. Furthermore, it allows log monitoring tools to accurately group similar events together.
Checklist
djLint-er on any new code
changes
What type of PR is this?
Added/updated tests?
Related PRs, Issues etc