Repository navigation
feat(fetch-results): publish matchfinished when a match is finished - #18
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…bles Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e the status Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second half of #4: the
fetch-resultsLambda, which uses the Treize Mondial adapter (#17) and publishesMatchFinishedon a new event bus.final-whistleevent bus and theMatchFinishedcontract insrc/events(D28), to be shared withnotify's rule in MatchFinished bus and notify #5.fetch-results: validates the match key, looks the match up and publishes once it is finished. Every outcome is logged as JSON with the match id, and failures are rethrown so the invocation is retried.events:PutEventson the bus, and a log group with a 30-day retention.For reviewers:
publishMatchFinishedturns a rejection into an error, so a score is retried rather than lost.Closes #4.