fix: save window state before withdraw in _windows_set_titlebar_color when window not yet shown#2811
Open
BRUNO1993-CIBER wants to merge 1 commit into
Conversation
… when window not yet shown When withdraw() is called before mainloop(), _state_before_windows_set_titlebar_color was never set in the else branch, remaining None. The restore block then called self.state(None) which is a no-op query, leaving the window permanently hidden. Fixes TomSchimansky#2810
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2810
Problem
When
withdraw()is called beforemainloop(),_state_before_windows_set_titlebar_colorwas never assigned in the
elsebranch of_windows_set_titlebar_color(), remainingNone.The restore block then executed
self.state(None)which is a no-op (query only),leaving the window permanently hidden after the titlebar color change.
Fix
Save
self.state()before callingsuper().withdraw()in theelsebranch,mirroring what the
if self._window_existsbranch already does correctly.Change
1 line added in
_windows_set_titlebar_color()— no behavior change for existing working paths.