fix(ethicalads): Handle SyntaxError from empty selector in Safari - #444
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
SyntaxError: '' is not a valid selector.that occurred in Safari 26.6 whenwindow.ethicalads.reload()was called. The error originated from the third-partyethicalads.min.jslibrary internally callingdocument.querySelectorAll('')with an empty selector string, which Safari considers invalid.The issue manifested as an unhandled Promise rejection because the call to
window.ethicalads.reload()insrc/components/EthicalAds.tsxdid not include a.catch()handler.Changes made:
src/components/EthicalAds.tsx: Modifiedwindow.ethicalads.reload();towindow.ethicalads.reload().catch(function() {});to gracefully handle the Promise rejection and prevent it from becoming an unhandled error.src/lib/sentry-filter.ts: Added a new filter rule to suppress Sentry events forSyntaxErrorwith the message'' is not a valid selector. This acts as a safety net to prevent similar errors from being reported in the future, especially if they originate from different contexts or browsers.Fixes BLOG-6C
This PR was automatically generated by Sentry. You can adjust this setting at any time.