Fix/update string type conditions - #16
Draft
Hamedblue1381 wants to merge 9 commits into
Draft
Conversation
Contributor
Author
|
I havent figured out what function names for |
Hamedblue1381
force-pushed
the
fix/update-string-type-conditions
branch
from
July 8, 2025 16:27
a1a2676 to
e59121e
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR closes issue #14.
The problem was:
encodingwas not"ascii".stringas a type, which should not be valid.What I did
stringas valid types.sia.addString{N|8|16|32|64}andsia.readString{N|8|16|32|64}oraddAscii{number}andreadAscii{number}based on the string type, not theencoding.encodingfield is now ignored, as their respective SIA libraries do not have specific functions or arguments related to encodings.Tests
stringnow throw errors.string8,string16,string32,string64all generate correct code.Notes
stringN,string8,string16,string32, orstring64.encodingfield is ignored in the Python, Go, and C++ generators — type controls everything now.