Skip to content

Change for deployment rollout#8

Open
vbotingnon wants to merge 5 commits into
TheYkk:masterfrom
vbotingnon:master
Open

Change for deployment rollout#8
vbotingnon wants to merge 5 commits into
TheYkk:masterfrom
vbotingnon:master

Conversation

@vbotingnon

Copy link
Copy Markdown
Contributor

Hello, for my project it made more sense to do with deployments so that the service is not unavailable.

Comment thread handlers.py Outdated
@TheYkk

TheYkk commented Mar 7, 2021

Copy link
Copy Markdown
Owner

Hi Valdir thanks for your pr, but what if user only has a pod object?

@vbotingnon

Copy link
Copy Markdown
Contributor Author

One option would be to implement an alternative for him to configure via POD or Deployments. Thus, it started to work only with deployments, which ensures that the service does not go down.

@TheYkk

TheYkk commented Mar 7, 2021

Copy link
Copy Markdown
Owner

If you can add pod restart , I would like to merge this pr.

@almson

almson commented Mar 25, 2022

Copy link
Copy Markdown

I don't think synator should restart or redeploy anythings. Restarting on secret/config update is a general problem that should be solved by a separate operator (or, ideally, kubernetes itself).

@TheYkk

TheYkk commented Mar 25, 2022

Copy link
Copy Markdown
Owner

I created synator because K8s can't do this.

@almson

almson commented Mar 27, 2022

Copy link
Copy Markdown

@TheYkk Then you should create another controller called, eg, "Rystartor" which handles restarting of pods/deployments. It would have nothing to do with Synator and would track both automatic and manual changes to ConfigMaps and Secrets.

Why do you think putting two unrelated pieces of functionality into the same controller is a good idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants