Skip to content

fix(android): compare complete source configuration - #5067

Open
OskarEichler wants to merge 1 commit into
TheWidlarzGroup:support/6.x.xfrom
OskarEichler:codex/fix-android-source-equality
Open

OskarEichler wants to merge 1 commit into
TheWidlarzGroup:support/6.x.xfrom
OskarEichler:codex/fix-android-source-equality

Conversation

@OskarEichler

Copy link
Copy Markdown

Fixes

  • include request headers, metadata, and chunkless-preparation mode in Android source equality so changing any of them reloads the media source
  • compare side-loaded track values instead of freshly parsed object identities
  • make Source and its nested configuration values obey the equals/hashCode contract

Previously, changing only authentication headers could leave the old media source running, while an unchanged side-loaded track list always looked different. Source.hashCode() also used a different field set from equals().

Regression coverage

The v6 branch has no test suite (yarn test reports no test available), so no source-model unit test can be added without introducing a new Android harness. Verified with:

  • YARN_NODE_LINKER=node-modules yarn check-android
  • YARN_NODE_LINKER=node-modules yarn build
  • YARN_NODE_LINKER=node-modules yarn lint
  • git diff --check

Breaking changes

None. Source changes that were previously ignored now correctly trigger a reload; unchanged side-loaded tracks no longer trigger one spuriously.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant