Repository navigation
fix(android): compare complete source configuration - #5067
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Sourceand its nested configuration values obey theequals/hashCodecontractPreviously, changing only authentication headers could leave the old media source running, while an unchanged side-loaded track list always looked different.
Source.hashCode()also used a different field set fromequals().Regression coverage
The v6 branch has no test suite (
yarn testreportsno test available), so no source-model unit test can be added without introducing a new Android harness. Verified with:YARN_NODE_LINKER=node-modules yarn check-androidYARN_NODE_LINKER=node-modules yarn buildYARN_NODE_LINKER=node-modules yarn lintgit diff --checkBreaking changes
None. Source changes that were previously ignored now correctly trigger a reload; unchanged side-loaded tracks no longer trigger one spuriously.