Skip to content

fix(android): guard picture-in-picture state - #5065

Open
OskarEichler wants to merge 1 commit into
TheWidlarzGroup:support/6.x.xfrom
OskarEichler:codex/fix-android-pip-guards
Open

OskarEichler wants to merge 1 commit into
TheWidlarzGroup:support/6.x.xfrom
OskarEichler:codex/fix-android-pip-guards

Conversation

@OskarEichler

Copy link
Copy Markdown

Fixes

  • avoid dereferencing the player when picture-in-picture is requested before player initialization
  • only construct an Android Rational aspect ratio when both video dimensions are positive, preventing audio-only/unknown-size crashes
  • clear saved root-view visibility state after automatic PiP exit so repeated sessions restore the current state
  • make manual PiP exit safe when the player view is temporarily detached

Regression coverage

The v6 branch has no test suite (yarn test reports no test available), so no Android lifecycle regression test can be added without a new harness. Verified with:

  • YARN_NODE_LINKER=node-modules yarn check-android
  • YARN_NODE_LINKER=node-modules yarn build
  • YARN_NODE_LINKER=node-modules yarn lint
  • git diff --check

Breaking changes

None.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant