Repository navigation
fix(android): cancel stale source initialization - #5057
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
finallyon success and every early returnWhy
The current checks use
viewHasDropped && runningSource == source. That only aborts one narrow combination; a changed source explicitly allows the old request to continue. The old request can then initialize media using a mixture of captured and current source fields. Each attempt also creates anewSingleThreadExecutor()without shutting it down, retaining a thread after its one task completes.Verification
yarn buildyarn lintyarn check-androidgit diff --checkThe v6 repository has no native unit-test or standalone Android compilation harness; hosted Android CI remains the Java compilation gate.
Breaking changes
None. Only dropped/superseded initialization work is cancelled.